Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: test4 genesis.json and suggested config.toml #2508

Merged
merged 33 commits into from
Jul 10, 2024

Conversation

zivkovicmilos
Copy link
Member

@zivkovicmilos zivkovicmilos commented Jul 4, 2024

Description

This PR adds the test4 genesis.json and suggested config.toml.
It also includes a relevant README to highlight important config.toml params.

⚠️ IMPORTANT ⚠️

You can view the genesis transactions that differ from the examples folder here:
dev/zivkovicmilos/test4-genesis...dev/zivkovicmilos/test4-genesis-prepared

In case anyone is curious, I extracted the bech32 representation of the public keys from the genesis.json using this script:

package main

import (
	"fmt"

	_ "github.com/gnolang/gno/gno.land/pkg/gnoland"
	"github.com/gnolang/gno/tm2/pkg/bft/types"
)

func main() {
	path := "../gno/misc/deployments/test4.gno.land/genesis.json"

	doc, err := types.GenesisDocFromFile(path)
	if err != nil {
		panic(err)
	}

	for _, v := range doc.Validators {
		fmt.Printf("Name: %s\n", v.Name)
		fmt.Printf("Address: %s\n", v.Address)
		fmt.Printf("PubKey: %s\n", v.PubKey.String())

		fmt.Printf("\n===========================\n\n")
	}
}
Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@zivkovicmilos zivkovicmilos added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Jul 4, 2024
@zivkovicmilos zivkovicmilos self-assigned this Jul 4, 2024
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.02%. Comparing base (6432573) to head (6a61abb).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2508   +/-   ##
=======================================
  Coverage   55.02%   55.02%           
=======================================
  Files         595      595           
  Lines       79645    79645           
=======================================
+ Hits        43824    43827    +3     
+ Misses      32503    32500    -3     
  Partials     3318     3318           
Flag Coverage Δ
misc/autocounterd 0.00% <ø> (ø)
misc/genproto 0.00% <ø> (ø)
misc/genstd 80.54% <ø> (ø)
misc/goscan 0.00% <ø> (ø)
misc/logos 17.68% <ø> (+0.30%) ⬆️
misc/loop 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@r3v4s
Copy link
Contributor

r3v4s commented Jul 5, 2024

suggested config.toml

Just be to sure, is this suggestion stands for..

  • initial validator's val node
  • initial validator's sentry node
  • just basic full node that willing to connect existing chain

or something else?

@moul moul marked this pull request as ready for review July 5, 2024 01:09
@moul moul requested review from moul and a team as code owners July 5, 2024 01:09
@moul moul marked this pull request as draft July 5, 2024 01:09
@zivkovicmilos
Copy link
Member Author

IMPORTANT

You can view the genesis transactions that differ from the examples folder here:
dev/zivkovicmilos/test4-genesis...dev/zivkovicmilos/test4-genesis-prepared

@zivkovicmilos zivkovicmilos requested a review from moul July 9, 2024 18:49
@zivkovicmilos zivkovicmilos marked this pull request as ready for review July 9, 2024 18:49
@zivkovicmilos zivkovicmilos added the don't merge Please don't merge this functionality temporarily label Jul 9, 2024
thehowl pushed a commit that referenced this pull request Jul 9, 2024
@zivkovicmilos zivkovicmilos merged commit 194903d into master Jul 10, 2024
84 of 85 checks passed
@zivkovicmilos zivkovicmilos deleted the dev/zivkovicmilos/test4-genesis branch July 10, 2024 08:10
gfanton pushed a commit to gfanton/gno that referenced this pull request Jul 23, 2024
gfanton pushed a commit to gfanton/gno that referenced this pull request Jul 23, 2024
## Description

This PR adds the **test4** `genesis.json` and suggested `config.toml`.
It also includes a relevant README to highlight important `config.toml`
params.

⚠️  **IMPORTANT** ⚠️ 

You can view the genesis transactions that differ from the examples
folder here:

gnolang/gno@dev/zivkovicmilos/test4-genesis...dev/zivkovicmilos/test4-genesis-prepared

In case anyone is curious, I extracted the bech32 representation of the
public keys from the `genesis.json` using this script:

```go
package main

import (
	"fmt"

	_ "github.com/gnolang/gno/gno.land/pkg/gnoland"
	"github.com/gnolang/gno/tm2/pkg/bft/types"
)

func main() {
	path := "../gno/misc/deployments/test4.gno.land/genesis.json"

	doc, err := types.GenesisDocFromFile(path)
	if err != nil {
		panic(err)
	}

	for _, v := range doc.Validators {
		fmt.Printf("Name: %s\n", v.Name)
		fmt.Printf("Address: %s\n", v.Address)
		fmt.Printf("PubKey: %s\n", v.PubKey.String())

		fmt.Printf("\n===========================\n\n")
	}
}
```

<details><summary>Contributors' checklist...</summary>

- [x] Added new tests, or not needed, or not feasible
- [x] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [x] Updated the official documentation or not needed
- [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [ ] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>

---------

Co-authored-by: Manfred Touron <94029+moul@users.noreply.github.com>
Co-authored-by: Salvatore Mazzarino <salvatore.mazzarino@tendermint.com>
Co-authored-by: Blake <104744707+r3v4s@users.noreply.github.com>
@zivkovicmilos zivkovicmilos removed the don't merge Please don't merge this functionality temporarily label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related
Projects
Status: Done
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

6 participants